Merge pull request #199 from simoleo89/fix/modtool-sanction-rank-ceilings

fix(modtool): enforce permissions and sanction rank ceilings
This commit is contained in:
DuckieTM
2026-06-15 07:24:30 +02:00
committed by GitHub
7 changed files with 107 additions and 5 deletions
@@ -410,13 +410,16 @@ public class ModToolManager {
return;
}
if (target == null || !canModerateTarget(moderator, target.getHabboInfo().getId())) {
return;
}
SupportUserAlertedEvent alertedEvent = new SupportUserAlertedEvent(moderator, target, message, reason);
if (Emulator.getPluginManager().fireEvent(alertedEvent).isCancelled())
return;
if (target != null)
alertedEvent.target.getClient().sendResponse(new ModToolIssueHandledComposer(alertedEvent.message));
alertedEvent.target.getClient().sendResponse(new ModToolIssueHandledComposer(alertedEvent.message));
}
public void kick(Habbo moderator, Habbo target, String message) {
@@ -490,6 +493,17 @@ public class ModToolManager {
return bans;
}
public static boolean canModerateTarget(Habbo moderator, int targetUserId) {
if (moderator == null || targetUserId <= 0)
return false;
HabboInfo targetInfo = Emulator.getGameEnvironment().getHabboManager().getHabboInfo(targetUserId);
if (targetInfo == null)
return false;
return targetInfo.getRank().getId() < moderator.getHabboInfo().getRank().getId();
}
public void roomAction(Room room, Habbo moderator, boolean kickUsers, boolean lockDoor, boolean changeTitle) {
SupportRoomActionEvent roomActionEvent = new SupportRoomActionEvent(moderator, room, kickUsers, lockDoor, changeTitle);
Emulator.getPluginManager().fireEvent(roomActionEvent);
@@ -30,6 +30,10 @@ public class ModToolIssueDefaultSanctionEvent extends MessageHandler {
if (defaultSanction != null) {
Habbo target = Emulator.getGameEnvironment().getHabboManager().getHabbo(issue.reportedId);
if (!ModToolManager.canModerateTarget(this.client.getHabbo(), issue.reportedId)) {
return;
}
if (defaultSanction.banLength > 0) {
Emulator.getGameEnvironment().getModToolManager().ban(issue.reportedId, this.client.getHabbo(), defaultSanction.message, defaultSanction.banLength * 86400, ModToolBanType.ACCOUNT, modToolCategory.id);
} else if (defaultSanction.muteLength > 0) {
@@ -1,6 +1,8 @@
package com.eu.habbo.messages.incoming.modtool;
import com.eu.habbo.Emulator;
import com.eu.habbo.habbohotel.modtool.ScripterManager;
import com.eu.habbo.habbohotel.permissions.Permission;
import com.eu.habbo.messages.incoming.MessageHandler;
public class ModToolKickEvent extends MessageHandler {
@@ -11,6 +13,11 @@ public class ModToolKickEvent extends MessageHandler {
@Override
public void handle() throws Exception {
if (!this.client.getHabbo().hasPermission(Permission.ACC_SUPPORTTOOL)) {
ScripterManager.scripterDetected(this.client, Emulator.getTexts().getValue("scripter.warning.modtools.kick").replace("%username%", this.client.getHabbo().getHabboInfo().getUsername()));
return;
}
Emulator.getGameEnvironment().getModToolManager().kick(this.client.getHabbo(), Emulator.getGameEnvironment().getHabboManager().getHabbo(this.packet.readInt()), this.packet.readString());
}
}
@@ -28,6 +28,10 @@ public class ModToolSanctionAlertEvent extends MessageHandler {
Habbo habbo = Emulator.getGameEnvironment().getHabboManager().getHabbo(userId);
if (habbo != null) {
if (!ModToolManager.canModerateTarget(this.client.getHabbo(), userId)) {
return;
}
ModToolSanctions modToolSanctions = Emulator.getGameEnvironment().getModToolSanctions();
if (Emulator.getConfig().getBoolean("hotel.sanctions.enabled")) {
@@ -55,4 +59,4 @@ public class ModToolSanctionAlertEvent extends MessageHandler {
}
}
}
}
}
@@ -30,6 +30,10 @@ public class ModToolSanctionMuteEvent extends MessageHandler {
Habbo habbo = Emulator.getGameEnvironment().getHabboManager().getHabbo(userId);
if (habbo != null) {
if (!ModToolManager.canModerateTarget(this.client.getHabbo(), userId)) {
return;
}
ModToolSanctions modToolSanctions = Emulator.getGameEnvironment().getModToolSanctions();
if (Emulator.getConfig().getBoolean("hotel.sanctions.enabled")) {
@@ -67,4 +71,4 @@ public class ModToolSanctionMuteEvent extends MessageHandler {
}
}
}
}
}
@@ -29,6 +29,10 @@ public class ModToolSanctionTradeLockEvent extends MessageHandler {
Habbo habbo = Emulator.getGameEnvironment().getHabboManager().getHabbo(userId);
if (habbo != null) {
if (!ModToolManager.canModerateTarget(this.client.getHabbo(), userId)) {
return;
}
ModToolSanctions modToolSanctions = Emulator.getGameEnvironment().getModToolSanctions();
if (Emulator.getConfig().getBoolean("hotel.sanctions.enabled")) {
@@ -57,4 +61,4 @@ public class ModToolSanctionTradeLockEvent extends MessageHandler {
}
}
}
}
}