fix(wired): bound avatar condition payloads

2026-06-20 07:26:18 +00:00 · 2026-06-17 19:21:54 +02:00
parent 416d0bb088
commit 25e38fbbeb
4 changed files with 141 additions and 23 deletions
@@ -0,0 +1,47 @@
+package com.eu.habbo.habbohotel.items.interactions.wired.conditions;
+
+import com.eu.habbo.habbohotel.wired.core.WiredSourceUtil;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+class WiredConditionAvatarPayloadGuardTest {
+    @Test
+    void effectIdsSourcesAndQuantifiersAreBounded() {
+        WiredConditionHabboHasEffect condition = new WiredConditionHabboHasEffect(1, 1, null, "", 0, 0);
+
+        assertEquals(0, condition.normalizeEffectId(-1));
+        assertEquals(23, condition.normalizeEffectId(23));
+        assertEquals(WiredConditionHabboHasEffect.MAX_EFFECT_ID, condition.normalizeEffectId(Integer.MAX_VALUE));
+        assertEquals(WiredSourceUtil.SOURCE_CLICKED_USER, condition.normalizeUserSource(WiredSourceUtil.SOURCE_CLICKED_USER));
+        assertEquals(WiredSourceUtil.SOURCE_TRIGGER, condition.normalizeUserSource(777));
+        assertEquals(1, condition.normalizeQuantifier(1, 0));
+        assertEquals(0, condition.normalizeQuantifier(5, 0));
+    }
+
+    @Test
+    void handItemIdsSourcesAndQuantifiersAreBounded() {
+        WiredConditionHabboHasHandItem condition = new WiredConditionHabboHasHandItem(1, 1, null, "", 0, 0);
+
+        assertEquals(0, condition.normalizeHandItem(-1));
+        assertEquals(9, condition.normalizeHandItem(9));
+        assertEquals(WiredConditionHabboHasHandItem.MAX_HAND_ITEM_ID, condition.normalizeHandItem(Integer.MAX_VALUE));
+        assertEquals(WiredSourceUtil.SOURCE_SIGNAL, condition.normalizeUserSource(WiredSourceUtil.SOURCE_SIGNAL));
+        assertEquals(WiredSourceUtil.SOURCE_TRIGGER, condition.normalizeUserSource(-44));
+        assertEquals(1, condition.normalizeQuantifier(1));
+        assertEquals(0, condition.normalizeQuantifier(8));
+    }
+
+    @Test
+    void badgeCodesSourcesAndQuantifiersAreBounded() {
+        WiredConditionHabboWearsBadge condition = new WiredConditionHabboWearsBadge(1, 1, null, "", 0, 0);
+
+        assertEquals("", condition.normalizeBadge(null));
+        assertEquals("ADM", condition.normalizeBadge(" ADM "));
+        assertEquals(WiredConditionHabboWearsBadge.MAX_BADGE_CODE_LENGTH, condition.normalizeBadge("x".repeat(200)).length());
+        assertEquals(WiredSourceUtil.SOURCE_SELECTOR, condition.normalizeUserSource(WiredSourceUtil.SOURCE_SELECTOR));
+        assertEquals(WiredSourceUtil.SOURCE_TRIGGER, condition.normalizeUserSource(66));
+        assertEquals(1, condition.normalizeQuantifier(1, 0));
+        assertEquals(0, condition.normalizeQuantifier(3, 0));
+    }
+}