Sweep targeted typecheck errors: 11 fixes across 9 files

- ProductImageUtility: 'CatalogPageMessageProductData.I' was clearly a
  placeholder/typo in the WALL branch — getProductCategory's first
  param is FurnitureType, so use the enclosing productType.
- YouTubePlayerView: IRoomUserData has webID, not userId. Two
  spectator/watcher-list sites used the wrong field.
- AvatarInfoWidgetView REQUEST_MANIPULATION handler: avatarInfo is
  IAvatarInfo (union); .category / .id only exist on AvatarInfoFurni.
  Type-guard before reading.
- InfoStandWidgetPetView: deleted the duplicate local 'interface
  AvatarInfoPet' — was shadowing the imported one. Drop AvatarInfoPet
  from the import (local interface stands alone).
- FurnitureExternalImageView: missing GetSessionDataManager import (the
  reportedUserId field reads it inline). Added.
- GroupCreatorView setGroupData call: null values for groupName /
  groupDescription / groupColors / groupBadgeParts where IGroupData
  expects string / number[] / GroupBadgePart[]. Empty defaults. Also
  added the previously-omitted groupHasForum field.
- ContextMenuView + WiredCreatorToolsView: 'return () =>
  ticker.remove(updateOverlays)' — Pixi Ticker.remove() returns the
  ticker, leaking the value to React's EffectCallback cleanup which
  expects 'void | (() => void)'. Wrap in block body.
- Deleted src/components/room/widgets/chat/ChatWidgetWindowView_old.tsx
  — dead code (zero references in the codebase), tripping the
  NitroCardHeaderView onCloseClick prop change.

Net tsgo error count: -11.
This commit is contained in:
simoleo89
2026-05-11 21:34:34 +02:00
parent 71a1586866
commit 019295226d
9 changed files with 16 additions and 106 deletions
+4 -4
View File
@@ -117,10 +117,10 @@ export const YouTubePlayerView: FC<{}> = () =>
for (let i = 0; i < 500; i++)
{
const userData = roomSession.userDataManager.getUserDataByIndex(i);
if (userData && userData.name && userData.type === 1 && !seen.has(userData.userId))
if (userData && userData.name && userData.type === 1 && !seen.has(userData.webID))
{
seen.add(userData.userId);
users.push({ id: userData.userId, name: userData.name, look: userData.figure });
seen.add(userData.webID);
users.push({ id: userData.webID, name: userData.name, look: userData.figure });
}
}
setSpectators(users);
@@ -663,7 +663,7 @@ export const YouTubePlayerView: FC<{}> = () =>
const ud = rs.userDataManager.getUserData(uid);
if (ud && ud.name)
{
watchers.push({ id: ud.userId, name: ud.name, look: ud.figure });
watchers.push({ id: ud.webID, name: ud.name, look: ud.figure });
}
}
}