From 8b44aee0df608c801d0729643da8c88602fdbf60 Mon Sep 17 00:00:00 2001 From: medievalshell <150498573+medievalshell@users.noreply.github.com> Date: Wed, 3 Jun 2026 13:04:07 +0200 Subject: [PATCH 1/2] Fix navigator tabs locking after entering room creator setTab updated currentTabCode/currentFilter but never reset isCreatorOpen, so after opening the room creator, clicking another navigator tab changed the active tab code while the creator view stayed rendered (NavigatorView renders the search and creator views mutually exclusively based on isCreatorOpen). This left users stuck in the creator unable to switch tabs. Reset isCreatorOpen to false in setTab so selecting any tab also closes the creator. --- src/hooks/navigator/navigatorUiStore.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hooks/navigator/navigatorUiStore.ts b/src/hooks/navigator/navigatorUiStore.ts index 709207a..c4899d7 100644 --- a/src/hooks/navigator/navigatorUiStore.ts +++ b/src/hooks/navigator/navigatorUiStore.ts @@ -64,6 +64,6 @@ export const useNavigatorUiStore = createNitroStore set({ needsInit: false }), requestSearch: () => set({ needsSearch: true }), consumeSearchRequest: () => set({ needsSearch: false }), - setTab: (code) => set({ currentTabCode: code, currentFilter: '' }), + setTab: (code) => set({ currentTabCode: code, currentFilter: '', isCreatorOpen: false }), setFilter: (value) => set({ currentFilter: value }) })); From 8c12d8f7b0c999cba7dae6d1de0bc960fb0a4e84 Mon Sep 17 00:00:00 2001 From: medievalshell <150498573+medievalshell@users.noreply.github.com> Date: Wed, 3 Jun 2026 13:12:18 +0200 Subject: [PATCH 2/2] Remove repo-specific git author/workflow rules from CLAUDE.md The house rules pinned a fixed commit author identity and personal git/CI workflow notes, which is arbitrary and incorrect for anyone else using Claude Code on this repo. Keep only the code-quality conventions (layout, tests, lint). --- CLAUDE.md | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/CLAUDE.md b/CLAUDE.md index cd950d9..b64a97f 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -387,22 +387,14 @@ See `docs/ARCHITECTURE.md` "Recently fixed" for fix shapes. ## House rules -- **Commit author**: `simoleo89 `. - When committing, pass these via per-command overrides - (`git -c user.name=simoleo89 -c user.email=...`) — do NOT modify the - global git config. -- **No `claude/...` branch names** — auto-generated names should be - renamed before pushing. Prefer `feat/`. - **Never merge a branch that violates the layout convention** above. - The `feat/react19-hooks-adapter` branch (deleted) put hooks under - `src/components/...`; that's wrong and a recurring temptation. + The hooks-adapter approach that put hooks under `src/components/...` is + wrong and a recurring temptation. - **Skip-motivated god-hook splits are fine** — when a hook's actions - mutate internal state, document the reason in the commit message and - move on rather than forcing a bad split. -- **`yarn test` must stay green** on every commit. Currently 193/193. - The GitHub Actions workflow at `.github/workflows/ci.yml` runs - `yarn typecheck` + `yarn test --run` on every push to `main` / - `feat/**` and on every PR — both must pass. + mutate internal state, document the reason and move on rather than + forcing a bad split. +- **`yarn test` must stay green**. `yarn typecheck` + `yarn test --run` + must both pass. - **Lint baseline**: don't regress. Some pre-existing errors (`FC<{}>`, `IMessageEvent | undefined` redundant union in the local sandbox where the renderer SDK isn't installed) are out of scope here.