duckietm/Nitro-V3
1
0
Fork 0
mirror of https://github.com/duckietm/Nitro-V3.git synced 2026-06-20 15:36:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(navigator): drive search via TanStack Query + setTab/setFilter UI store

Browse Source 
NavigatorView reads searchResult/isFetching from useNavigatorSearch
instead of useNavigatorData/useNavigatorUiState. Tab clicks call
setTab(code) on the UI store, which atomically updates the query key
and triggers refetch. The 4 lifecycle useEffect blocks driving the
old imperative flow (needsSearch / reloadCurrentSearch / markReady)
are removed — the query handles all of it now.

NavigatorSearchView has a debounced (300ms) onChange -> setFilter
that drives the same query refetch. Explicit submit (Enter / button)
skips the debounce and calls setFilter immediately.

linkTracker case 'search' now setTab + setFilter + show — no more
pendingSearch ref.

useNavigatorSearch.test.tsx: cast constructors as any to satisfy tsgo
against real renderer types while keeping runtime stubs no-arg-safe.

yarn typecheck / test / lint:hooks all clean (only pre-existing
floorplan environmental failures).
This commit is contained in:
simoleo89
2026-05-27 19:25:30 +02:00
parent ee3736474d
commit 26772f7073
3 changed files with 66 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/hooks/navigator/useNavigatorSearch.test.tsx
+18 -16
View File
@@ -1,6 +1,6 @@
/* @vitest-environment jsdom */
import { FlatCreatedEvent, NavigatorSearchComposer, NavigatorSearchEvent,
import { FlatCreatedEvent, NavigatorSearchEvent,
NavigatorSearchResultSet } from '@nitrots/nitro-renderer';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { act, cleanup, renderHook, waitFor } from '@testing-library/react';
@@ -32,14 +32,16 @@ const makeWrapper = (client: QueryClient) =>
/** Build a fake NavigatorSearchEvent that getParser() returns a result with `code`. */
const makeSearchEvent = (code: string) =>
{
const result = new NavigatorSearchResultSet() as any;
// Cast constructors as `any` so tsgo doesn't check required args against
// the real renderer SDK types (the mock stubs have no required args).
const result = new (NavigatorSearchResultSet as any)() as any;
result.code = code;
result.data = '';
result.results = [];
const ev = new NavigatorSearchEvent() as any;
const ev = new (NavigatorSearchEvent as any)() as any;
ev.getParser = () => ({ result });
return ev as NavigatorSearchEvent;
return ev;
};
const INITIAL_UI = {
@@ -82,7 +84,7 @@ describe('useNavigatorSearch', () =>
// Dispatch a search event — should be ignored (query disabled)
act(() =>
{
mockEventDispatcher.dispatchEvent(makeSearchEvent('public'));
mockEventDispatcher.dispatchEvent(makeSearchEvent('public') as any);
});
// Data must stay null
@@ -107,7 +109,7 @@ describe('useNavigatorSearch', () =>
// Simulate server response
act(() =>
{
mockEventDispatcher.dispatchEvent(makeSearchEvent('public'));
mockEventDispatcher.dispatchEvent(makeSearchEvent('public') as any);
});
// Query should resolve with the matching result
@@ -130,7 +132,7 @@ describe('useNavigatorSearch', () =>
await waitFor(() => expect(result.current.isFetching).toBe(true));
act(() =>
{
mockEventDispatcher.dispatchEvent(makeSearchEvent('public'));
mockEventDispatcher.dispatchEvent(makeSearchEvent('public') as any);
});
await waitFor(() => expect(result.current.isFetching).toBe(false));
@@ -145,7 +147,7 @@ describe('useNavigatorSearch', () =>
// Resolve with matching event
act(() =>
{
mockEventDispatcher.dispatchEvent(makeSearchEvent('public'));
mockEventDispatcher.dispatchEvent(makeSearchEvent('public') as any);
});
await waitFor(() => expect(result.current.isFetching).toBe(false));
@@ -171,7 +173,7 @@ describe('useNavigatorSearch', () =>
await waitFor(() => expect(result.current.isFetching).toBe(true));
act(() =>
{
mockEventDispatcher.dispatchEvent(makeSearchEvent('public'));
mockEventDispatcher.dispatchEvent(makeSearchEvent('public') as any);
});
await waitFor(() => expect(result.current.isFetching).toBe(false));
@@ -191,7 +193,7 @@ describe('useNavigatorSearch', () =>
// Resolve with events result
act(() =>
{
mockEventDispatcher.dispatchEvent(makeSearchEvent('events'));
mockEventDispatcher.dispatchEvent(makeSearchEvent('events') as any);
});
await waitFor(() => expect(result.current.isFetching).toBe(false));
@@ -212,7 +214,7 @@ describe('useNavigatorSearch', () =>
act(() =>
{
mockEventDispatcher.dispatchEvent(makeSearchEvent('public'));
mockEventDispatcher.dispatchEvent(makeSearchEvent('public') as any);
});
await waitFor(() =>
@@ -237,7 +239,7 @@ describe('useNavigatorSearch', () =>
// Dispatch an event for a DIFFERENT tab — should be rejected by accept filter
act(() =>
{
mockEventDispatcher.dispatchEvent(makeSearchEvent('wrong_tab'));
mockEventDispatcher.dispatchEvent(makeSearchEvent('wrong_tab') as any);
});
// Still fetching — the wrong-tab event was ignored
@@ -248,7 +250,7 @@ describe('useNavigatorSearch', () =>
// Now dispatch the correct one to unblock the test
act(() =>
{
mockEventDispatcher.dispatchEvent(makeSearchEvent('public'));
mockEventDispatcher.dispatchEvent(makeSearchEvent('public') as any);
});
await waitFor(() => expect(result.current.searchResult).not.toBeNull());
@@ -273,16 +275,16 @@ describe('useNavigatorSearch', () =>
await waitFor(() => expect(result.current.isFetching).toBe(true));
act(() =>
{
mockEventDispatcher.dispatchEvent(makeSearchEvent('public'));
mockEventDispatcher.dispatchEvent(makeSearchEvent('public') as any);
});
await waitFor(() => expect(result.current.isFetching).toBe(false));
// Dispatch FlatCreatedEvent — should trigger invalidateQueries
const flatCreatedEv = new FlatCreatedEvent() as any;
const flatCreatedEv = new (FlatCreatedEvent as any)() as any;
flatCreatedEv.getParser = () => ({ roomId: 999 });
act(() =>
{
mockEventDispatcher.dispatchEvent(flatCreatedEv);
mockEventDispatcher.dispatchEvent(flatCreatedEv as any);
});
await waitFor(() => expect(invalidateSpy).toHaveBeenCalled());