From 9d240501f0755bef68903002660f598cc6a037d8 Mon Sep 17 00:00:00 2001 From: simoleo89 <11816867+simoleo89@users.noreply.github.com> Date: Wed, 17 Jun 2026 22:02:24 +0200 Subject: [PATCH] a11y: add alt="" to decorative elements 11 JSX elements (catalog page/header images, game logo, playlist title gifs, crafting/favorite icons) had no alt attribute, so screen readers announce the raw src URL. They're all decorative chrome with adjacent text labels, so mark them decorative with alt="". --- src/components/catalog/CatalogClassicView.tsx | 2 +- .../catalog/views/catalog-header/CatalogHeaderView.tsx | 2 +- .../catalog/views/favorites/CatalogFavoritesView.tsx | 2 +- .../catalog/views/page/layout/CatalogLayoutDefaultView.tsx | 2 +- .../catalog/views/page/layout/CatalogLayoutTrophiesView.tsx | 2 +- src/components/game-center/views/GameView.tsx | 2 +- .../room/widgets/furniture/FurnitureCraftingView.tsx | 2 +- .../widgets/furniture/playlist-editor/DiskInventoryView.tsx | 4 ++-- .../widgets/furniture/playlist-editor/SongPlaylistView.tsx | 4 ++-- 9 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/components/catalog/CatalogClassicView.tsx b/src/components/catalog/CatalogClassicView.tsx index 0656d31..0f4fe9b 100644 --- a/src/components/catalog/CatalogClassicView.tsx +++ b/src/components/catalog/CatalogClassicView.tsx @@ -271,7 +271,7 @@ const CatalogClassicViewInner: FC<{}> = () =>
- { !!currentPage?.localization?.getImage(0) && } + { !!currentPage?.localization?.getImage(0) && }
diff --git a/src/components/catalog/views/catalog-header/CatalogHeaderView.tsx b/src/components/catalog/views/catalog-header/CatalogHeaderView.tsx index f750f01..9f79988 100644 --- a/src/components/catalog/views/catalog-header/CatalogHeaderView.tsx +++ b/src/components/catalog/views/catalog-header/CatalogHeaderView.tsx @@ -12,7 +12,7 @@ export const CatalogHeaderView: FC = props => const displayImageUrl = imageUrl ?? GetConfigurationValue('catalog.asset.image.url').replace('%name%', 'catalog_header_roombuilder'); return
- + { currentTarget.src = GetConfigurationValue('catalog.asset.image.url').replace('%name%', 'catalog_header_roombuilder'); } } /> diff --git a/src/components/catalog/views/favorites/CatalogFavoritesView.tsx b/src/components/catalog/views/favorites/CatalogFavoritesView.tsx index 0de88c5..6f1366e 100644 --- a/src/components/catalog/views/favorites/CatalogFavoritesView.tsx +++ b/src/components/catalog/views/favorites/CatalogFavoritesView.tsx @@ -133,7 +133,7 @@ export const CatalogFavoritesView: FC = props => { /* Furni icon */ }
{ fav.iconUrl - ? + ? : fav.nodeIconId !== null ? : diff --git a/src/components/catalog/views/page/layout/CatalogLayoutDefaultView.tsx b/src/components/catalog/views/page/layout/CatalogLayoutDefaultView.tsx index f41ff31..f99b9ab 100644 --- a/src/components/catalog/views/page/layout/CatalogLayoutDefaultView.tsx +++ b/src/components/catalog/views/page/layout/CatalogLayoutDefaultView.tsx @@ -95,7 +95,7 @@ export const CatalogLayoutDefaultView: FC = props => { !currentOffer &&
{ !!page.localization.getImage(1) && - } + }
}
diff --git a/src/components/catalog/views/page/layout/CatalogLayoutTrophiesView.tsx b/src/components/catalog/views/page/layout/CatalogLayoutTrophiesView.tsx index 6bc187c..6412ce6 100644 --- a/src/components/catalog/views/page/layout/CatalogLayoutTrophiesView.tsx +++ b/src/components/catalog/views/page/layout/CatalogLayoutTrophiesView.tsx @@ -99,7 +99,7 @@ export const CatalogLayoutTrophiesView: FC = props =>
:
{ !!page.localization.getImage(1) && - } + }
diff --git a/src/components/game-center/views/GameView.tsx b/src/components/game-center/views/GameView.tsx index c5d3561..79ee92f 100644 --- a/src/components/game-center/views/GameView.tsx +++ b/src/components/game-center/views/GameView.tsx @@ -40,7 +40,7 @@ export const GameView = () => return { LocalizeText(`gamecenter.${ selectedGame.gameNameId }.description_title`) } - + { (accountStatus.hasUnlimitedGames || accountStatus.freeGamesLeft > 0) && <>
- + ); }; diff --git a/src/components/room/widgets/furniture/playlist-editor/SongPlaylistView.tsx b/src/components/room/widgets/furniture/playlist-editor/SongPlaylistView.tsx index 95289a7..ccfa1e4 100644 --- a/src/components/room/widgets/furniture/playlist-editor/SongPlaylistView.tsx +++ b/src/components/room/widgets/furniture/playlist-editor/SongPlaylistView.tsx @@ -29,7 +29,7 @@ export const SongPlaylistView: FC = props => return (<>
- +

{ LocalizeText('playlist.editor.playlist') }

@@ -49,7 +49,7 @@ export const SongPlaylistView: FC = props =>
{ LocalizeText('playlist.editor.add.songs.to.your.playlist') }
{ LocalizeText('playlist.editor.text.click.song.to.choose.click.again.to.move') }
- + } { (playlist && playlist.length > 0) && <>