mirror of
https://github.com/duckietm/Nitro-V3.git
synced 2026-06-19 15:06:20 +00:00
security: don't dump the SSO ticket in the prepare() diagnostic log
The `[App] prepare() start` console.warn was including the full SSO ticket from `window.location.search`. SSO tickets are one-shot bearer credentials — any leak (copied logs in a bug report, screen share, malicious browser extension reading console output) grants single-use access to the user's session. Replace the actual ticket with a boolean.
This commit is contained in:
+6
-1
@@ -477,11 +477,16 @@ export const App: FC<{}> = props =>
|
||||
{
|
||||
const prepare = async (width: number, height: number) =>
|
||||
{
|
||||
// Don't dump the actual SSO ticket — it's a one-shot bearer
|
||||
// credential that grants access to the user's session, so
|
||||
// logging it in console.warn would leak it via copied logs
|
||||
// / screen shares / browser extension hooks. Boolean flag is
|
||||
// enough for the diagnostic.
|
||||
console.warn('[App] prepare() start', {
|
||||
hasNitroConfig: !!window.NitroConfig,
|
||||
ssoTicketInConfig: !!window.NitroConfig?.['sso.ticket'],
|
||||
hasRememberLocal: !!GetRememberLogin(),
|
||||
urlSso: new URLSearchParams(window.location.search).get('sso')
|
||||
hasUrlSso: !!new URLSearchParams(window.location.search).get('sso')
|
||||
});
|
||||
|
||||
const bootLabel = taskLabel('loading.task.boot', 'Avvio in corso...');
|
||||
|
||||
Reference in New Issue
Block a user