From 53fc5f09fd528a80ddc8c5d48617f65ff18af45b Mon Sep 17 00:00:00 2001 From: simoleo89 Date: Wed, 13 May 2026 21:57:35 +0200 Subject: [PATCH] ci: create renderer symlink after yarn install, not before MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Yarn cleans up anything in node_modules that's not declared in package.json, so the previous order (symlink → yarn install) wiped the link and tsgo could not resolve @nitrots/nitro-renderer. Move the symlink step after both installs. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/ci.yml | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f1ab182..f6dbe46 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -36,15 +36,6 @@ jobs: Nitro-V3/yarn.lock Nitro_Render_V3/yarn.lock - # The renderer SDK is consumed via a filesystem symlink in - # node_modules/@nitrots/nitro-renderer; create it explicitly so - # tsgo (TS 7 native preview) can resolve the tsconfig `include` - # entry pointing at the renderer's `src/**/*.ts`. - - name: Symlink renderer into client node_modules - run: | - mkdir -p Nitro-V3/node_modules/@nitrots - ln -sfn ../../../Nitro_Render_V3 Nitro-V3/node_modules/@nitrots/nitro-renderer - - name: Install renderer SDK deps working-directory: Nitro_Render_V3 run: yarn install --frozen-lockfile @@ -53,6 +44,18 @@ jobs: working-directory: Nitro-V3 run: yarn install --frozen-lockfile + # The renderer SDK is consumed via a filesystem symlink in + # node_modules/@nitrots/nitro-renderer; create it AFTER yarn + # install (otherwise yarn would clean it up since the package + # isn't declared in package.json). tsgo (TS 7 native preview) + # then resolves the tsconfig `include` entry pointing at the + # renderer's `src/**/*.ts`. + - name: Symlink renderer into client node_modules + run: | + mkdir -p Nitro-V3/node_modules/@nitrots + ln -sfn ../../../Nitro_Render_V3 Nitro-V3/node_modules/@nitrots/nitro-renderer + ls -la Nitro-V3/node_modules/@nitrots/ + - name: Type check (tsgo) working-directory: Nitro-V3 run: yarn typecheck