From 5d7a20ac39576908c9bf70f8e29df6f4d2c3b58a Mon Sep 17 00:00:00 2001 From: simoleo89 Date: Wed, 13 May 2026 22:02:15 +0200 Subject: [PATCH] ci: use absolute symlink target + check out feat/react19-event-bus on the renderer fork MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two follow-up fixes after the first CI run failed with TS2307 across ~250 files: 1. The relative symlink target `../../../Nitro_Render_V3` resolves from inside `Nitro-V3/node_modules/@nitrots/nitro-renderer` to `Nitro-V3/Nitro_Render_V3` (one too few `..`) — that path doesn't exist, so tsgo couldn't find the renderer SDK and bailed on every `@nitrots/nitro-renderer` import. Switch to an absolute target via ${{ github.workspace }}. 2. The client depends on renderer API additions (`allowUnderpass` on RoomSettingsData, `sendBackgroundMessage` on IRoomSession, the NitroConfig Window declaration alignment) that live on `feat/react19-event-bus` of `simoleo89/Nitro_Render_V3` and not on `duckietm/Nitro_Render_V3:main`. Point the checkout at the fork + that branch so tsgo sees what the local working tree sees. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/ci.yml | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f6dbe46..42d68d5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,10 +21,17 @@ jobs: with: path: Nitro-V3 + # The client tracks renderer changes that are pushed to the + # `feat/react19-event-bus` branch of `simoleo89/Nitro_Render_V3` + # (allowUnderpass + sendBackgroundMessage + Window NitroConfig + # alignment, etc.). `duckietm/Nitro_Render_V3:main` doesn't yet + # have those, so tsgo would fail right away if we checked that + # out instead. - name: Checkout Nitro_Render_V3 (sibling) uses: actions/checkout@v4 with: - repository: duckietm/Nitro_Render_V3 + repository: simoleo89/Nitro_Render_V3 + ref: feat/react19-event-bus path: Nitro_Render_V3 - name: Setup Node 22 @@ -50,11 +57,18 @@ jobs: # isn't declared in package.json). tsgo (TS 7 native preview) # then resolves the tsconfig `include` entry pointing at the # renderer's `src/**/*.ts`. + # + # Use an absolute path so the link target is unambiguous + # regardless of the cwd that reads it. A relative target like + # `../../../Nitro_Render_V3` resolves to + # `Nitro-V3/Nitro_Render_V3` (one too few `..`), which doesn't + # exist and makes tsgo report TS2307 across the entire src/. - name: Symlink renderer into client node_modules run: | mkdir -p Nitro-V3/node_modules/@nitrots - ln -sfn ../../../Nitro_Render_V3 Nitro-V3/node_modules/@nitrots/nitro-renderer + ln -sfn "${{ github.workspace }}/Nitro_Render_V3" Nitro-V3/node_modules/@nitrots/nitro-renderer ls -la Nitro-V3/node_modules/@nitrots/ + ls Nitro-V3/node_modules/@nitrots/nitro-renderer/packages/api/src/ | head -5 - name: Type check (tsgo) working-directory: Nitro-V3