duckietm/Nitro-V3
1
0
Fork 0
mirror of https://github.com/duckietm/Nitro-V3.git synced 2026-06-19 15:06:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #192 from medievalshell/Dev

Browse Source 
Fix navigator tabs locking after entering room creator
This commit is contained in:
DuckieTM
2026-06-03 16:34:51 +02:00
committed by GitHub
parent 0cf45197d8 8c12d8f7b0
commit 7625520c4d
2 changed files with 7 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CLAUDE.md
+6 -14
View File
@@ -387,22 +387,14 @@ See `docs/ARCHITECTURE.md` "Recently fixed" for fix shapes.
## House rules ## House rules
- **Commit author**: `simoleo89 <simoleo89@users.noreply.github.com>`.
When committing, pass these via per-command overrides
(`git -c user.name=simoleo89 -c user.email=...`) — do NOT modify the
global git config.
- **No `claude/...` branch names** — auto-generated names should be
renamed before pushing. Prefer `feat/<description>`.
- **Never merge a branch that violates the layout convention** above. - **Never merge a branch that violates the layout convention** above.
The `feat/react19-hooks-adapter` branch (deleted) put hooks under The hooks-adapter approach that put hooks under `src/components/...` is
`src/components/...`; that's wrong and a recurring temptation. wrong and a recurring temptation.
- **Skip-motivated god-hook splits are fine** — when a hook's actions - **Skip-motivated god-hook splits are fine** — when a hook's actions
mutate internal state, document the reason in the commit message and mutate internal state, document the reason and move on rather than
move on rather than forcing a bad split. forcing a bad split.
- **`yarn test` must stay green** on every commit. Currently 193/193. - **`yarn test` must stay green**. `yarn typecheck` + `yarn test --run`
The GitHub Actions workflow at `.github/workflows/ci.yml` runs must both pass.
`yarn typecheck` + `yarn test --run` on every push to `main` /
`feat/**` and on every PR — both must pass.
- **Lint baseline**: don't regress. Some pre-existing errors (`FC<{}>`, - **Lint baseline**: don't regress. Some pre-existing errors (`FC<{}>`,
`IMessageEvent | undefined` redundant union in the local sandbox where `IMessageEvent | undefined` redundant union in the local sandbox where
the renderer SDK isn't installed) are out of scope here. the renderer SDK isn't installed) are out of scope here.
src/hooks/navigator/navigatorUiStore.ts
+1 -1
View File
@@ -64,6 +64,6 @@ export const useNavigatorUiStore = createNitroStore<NavigatorUiState & Navigator
markInitDone: () => set({ needsInit: false }), markInitDone: () => set({ needsInit: false }),
requestSearch: () => set({ needsSearch: true }), requestSearch: () => set({ needsSearch: true }),
consumeSearchRequest: () => set({ needsSearch: false }), consumeSearchRequest: () => set({ needsSearch: false }),
setTab: (code) => set({ currentTabCode: code, currentFilter: '' }), setTab: (code) => set({ currentTabCode: code, currentFilter: '', isCreatorOpen: false }),
setFilter: (value) => set({ currentFilter: value }) setFilter: (value) => set({ currentFilter: value })
})); }));