From 9ef6983632ed0958da549e204aaea1558283dacc Mon Sep 17 00:00:00 2001 From: simoleo89 Date: Wed, 13 May 2026 21:16:52 +0200 Subject: [PATCH] post cherry-pick: restore useEffectEvent wrapper + fix configuration import Two typecheck regressions surfaced after pulling duckietm PR #126 onto this branch: - NotificationBadgeReceivedBubbleView lost its `useEffectEvent` wrapper during conflict resolution. The PR rewrote the effect to use a plain `useEffect(..., [activeBadgeCodes.length])`; reintroduce the `requestBadgesIfEmpty = useEffectEvent(...)` shape that the rest of this branch uses, applied to the renamed activeBadgeCodes selector. - `src/bootstrap.ts` was importing `GetConfiguration` from the package alias `@nitrots/configuration`, which Vite resolves via filesystem alias but tsgo does not. Swap to the monolithic `@nitrots/nitro-renderer` re-export, matching how App.tsx already imports the same symbol. Both fixes get `yarn typecheck` green again and all 113 Vitest cases still pass. Co-Authored-By: Claude Opus 4.7 (1M context) --- src/bootstrap.ts | 2 +- .../bubble-layouts/NotificationBadgeReceivedBubbleView.tsx | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/bootstrap.ts b/src/bootstrap.ts index fe1eb9a..ac0b441 100644 --- a/src/bootstrap.ts +++ b/src/bootstrap.ts @@ -1,4 +1,4 @@ -import { GetConfiguration } from '@nitrots/configuration'; +import { GetConfiguration } from '@nitrots/nitro-renderer'; import { configFileUrl, getClientMode, installSecureFetch } from './secure-assets'; const ensureMobileViewport = () => diff --git a/src/components/notification-center/views/bubble-layouts/NotificationBadgeReceivedBubbleView.tsx b/src/components/notification-center/views/bubble-layouts/NotificationBadgeReceivedBubbleView.tsx index 333e51f..a8520a3 100644 --- a/src/components/notification-center/views/bubble-layouts/NotificationBadgeReceivedBubbleView.tsx +++ b/src/components/notification-center/views/bubble-layouts/NotificationBadgeReceivedBubbleView.tsx @@ -14,6 +14,8 @@ export const NotificationBadgeReceivedBubbleView: FC + { if(activeBadgeCodes.length === 0) SendMessageComposer(new RequestBadgesComposer()); });