From c170eb0a5bcb3af4abf2b898d93e974efc9261a5 Mon Sep 17 00:00:00 2001 From: medievalshell Date: Thu, 21 May 2026 00:31:14 +0200 Subject: [PATCH] fix(types): unblock CI typecheck on Dev MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two pre-existing tsgo failures surfaced by the loading-screen redesign PR: 1. AvatarEffectsView: import loadGamedata via the umbrella `@nitrots/nitro-renderer` instead of `@nitrots/utils`. The deep sub-package alias only exists in vite.config.mjs; tsgo resolves against node_modules, where only the umbrella is symlinked. Same symbol — index.ts re-exports `* from '@nitrots/utils'`. 2. DraggableWindow: `useRef()` -> `useRef(null)`. React 19 typings now require an initial value. Fixed once in a39aa37, re-introduced by the merge in 03bebe4. --- src/common/draggable-window/DraggableWindow.tsx | 2 +- src/components/avatar-effects/AvatarEffectsView.tsx | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/common/draggable-window/DraggableWindow.tsx b/src/common/draggable-window/DraggableWindow.tsx index e3b8695..20a17e9 100644 --- a/src/common/draggable-window/DraggableWindow.tsx +++ b/src/common/draggable-window/DraggableWindow.tsx @@ -30,7 +30,7 @@ export const DraggableWindow: FC = props => const [isDragging, setIsDragging] = useState(false); const [isPositioned, setIsPositioned] = useState(false); const [dragHandler, setDragHandler] = useState(null); - const elementRef = useRef(); + const elementRef = useRef(null); const bringToTop = useCallback(() => { let zIndex = 400; for (const existingWindow of CURRENT_WINDOWS) diff --git a/src/components/avatar-effects/AvatarEffectsView.tsx b/src/components/avatar-effects/AvatarEffectsView.tsx index eed77d8..92adb01 100644 --- a/src/components/avatar-effects/AvatarEffectsView.tsx +++ b/src/components/avatar-effects/AvatarEffectsView.tsx @@ -1,5 +1,4 @@ -import { AddLinkEventTracker, AvatarDirectionAngle, AvatarEffectActivatedComposer, GetConfiguration, GetSessionDataManager, ILinkEventTracker, RemoveLinkEventTracker } from '@nitrots/nitro-renderer'; -import { loadGamedata } from '@nitrots/utils'; +import { AddLinkEventTracker, AvatarDirectionAngle, AvatarEffectActivatedComposer, GetConfiguration, GetSessionDataManager, ILinkEventTracker, loadGamedata, RemoveLinkEventTracker } from '@nitrots/nitro-renderer'; import { ChangeEvent, FC, useCallback, useEffect, useMemo, useRef, useState } from 'react'; import { FaChevronLeft, FaChevronRight, FaSearch } from 'react-icons/fa'; import { LocalizeText, SendMessageComposer } from '../../api';