duckietm/Nitro-V3
1
0
Fork 0
mirror of https://github.com/duckietm/Nitro-V3.git synced 2026-06-20 07:26:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(friendbar): guarantee a single find-friends chip (filter null friends)

Browse Source 
The legacy bar rendered MAX_DISPLAY_COUNT FriendBarItemViews and padded
empty slots with null, so an empty online-friends list produced three
identical 'Trova Amici' buttons. The current bar already renders a single
explicit search chip, but harden it: filter null/undefined out of the
online-friends array before slicing/mapping so the search chip is the only
possible source of that affordance — exactly one, always.
This commit is contained in:
simoleo89
2026-06-14 20:26:47 +02:00
parent bd71d326fb
commit c311f3597d
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/friends/views/friends-bar/FriendsBarView.tsx
+9 -3
View File
@@ -79,11 +79,17 @@ export const FriendBarView: FC<{ onlineFriends: MessengerFriend[]; requestsCount
// below uses it, so a stale `indexOffset` (after the list shrinks or the fit // below uses it, so a stale `indexOffset` (after the list shrinks or the fit
// grows) renders correctly and self-corrects on the next arrow click — no // grows) renders correctly and self-corrects on the next arrow click — no
// write-back effect needed. // write-back effect needed.
const maxOffset = Math.max(0, (onlineFriends.length - maxVisible)); // Defensive: never let a null/undefined slip into the friend map. The
// legacy bar padded empty slots with `null` and rendered each as a
// FriendBarItemView (which falls back to the "find friends" chip), so an
// empty list produced THREE "Trova Amici" buttons. Filtering here makes the
// search chip below the ONLY source of that affordance — exactly one, always.
const validFriends = onlineFriends.filter(Boolean);
const maxOffset = Math.max(0, (validFriends.length - maxVisible));
const safeOffset = Math.min(indexOffset, maxOffset); const safeOffset = Math.min(indexOffset, maxOffset);
const canScrollLeft = (safeOffset > 0); const canScrollLeft = (safeOffset > 0);
const canScrollRight = (safeOffset < maxOffset); const canScrollRight = (safeOffset < maxOffset);
const visibleFriends = onlineFriends.slice(safeOffset, (safeOffset + maxVisible)); const visibleFriends = validFriends.slice(safeOffset, (safeOffset + maxVisible));
return ( return (
<motion.div <motion.div
@@ -135,7 +141,7 @@ export const FriendBarView: FC<{ onlineFriends: MessengerFriend[]; requestsCount
> >
<FriendBarItemView friend={ null } /> <FriendBarItemView friend={ null } />
</motion.div> </motion.div>
{ (!onlineFriends.length && (requestsCount <= 0)) && { (!validFriends.length && (requestsCount <= 0)) &&
<motion.div <motion.div
key="friend-empty" key="friend-empty"
variants={ itemVariants } variants={ itemVariants }