Phase A: clear all react-hooks/exhaustive-deps warnings via useEffectEvent or hoisting

Eliminate the four remaining missing-dependency warnings reported by
react-hooks v7. Each one was a real stale-closure or re-trigger hazard;
the fix matches the intent rather than just silencing the linter.

- src/App.tsx (line 448): wrap showSessionExpired with useEffectEvent
  (onSessionExpired) so the prepare effect doesn't re-run on every
  showSessionExpired identity change but still calls the latest
  callback. Replace the two in-effect call sites.
- src/components/furni-editor/views/FurniEditorSearchView.tsx: wrap
  the on-mount onSearch('', '', 1) call with useEffectEvent so the
  callback prop isn't a missing dependency.
- src/components/notification-center/views/bubble-layouts/
  NotificationBadgeReceivedBubbleView.tsx: wrap the
  "fetch badges only if empty on mount" check with useEffectEvent
  so badgeCodes.length isn't required as a dep (and won't re-fetch
  every count change).
- src/components/navigator/views/room-settings/
  NavigatorRoomSettingsRightsTabView.tsx: switch deps from
  roomData?.roomId to roomData (the body uses roomData.roomId after
  an early return; the linter wanted the whole object).
- src/api/ui-settings/UiSettingsContext.tsx: hoist ALL_CSS_VARS
  outside the component (it's a static constant).

After this, yarn eslint reports zero exhaustive-deps warnings across
the whole src/.

https://claude.ai/code/session_01GrR87LAqnAEyKG2ZbmQt5Q
This commit is contained in:
simoleo89
2026-05-11 16:31:51 +00:00
parent f18c917fc4
commit d382635597
5 changed files with 24 additions and 15 deletions
+5 -3
View File
@@ -1,5 +1,5 @@
import { GetAssetManager, GetAvatarRenderManager, GetCommunication, GetConfiguration, GetLocalizationManager, GetRoomEngine, GetRoomSessionManager, GetSessionDataManager, GetSoundManager, GetStage, GetTexturePool, GetTicker, HabboWebTools, LegacyExternalInterface, LoadGameUrlEvent, NitroEventType, NitroLogger, NitroVersion, PrepareRenderer } from '@nitrots/nitro-renderer'; import { GetAssetManager, GetAvatarRenderManager, GetCommunication, GetConfiguration, GetLocalizationManager, GetRoomEngine, GetRoomSessionManager, GetSessionDataManager, GetSoundManager, GetStage, GetTexturePool, GetTicker, HabboWebTools, LegacyExternalInterface, LoadGameUrlEvent, NitroEventType, NitroLogger, NitroVersion, PrepareRenderer } from '@nitrots/nitro-renderer';
import { FC, useCallback, useEffect, useRef, useState } from 'react'; import { FC, useCallback, useEffect, useEffectEvent, useRef, useState } from 'react';
import { ClearRememberLogin, GetRememberLogin, GetUIVersion, StoreRememberLoginFromPayload } from './api'; import { ClearRememberLogin, GetRememberLogin, GetUIVersion, StoreRememberLoginFromPayload } from './api';
import { Base } from './common'; import { Base } from './common';
import { LoadingView } from './components/loading/LoadingView'; import { LoadingView } from './components/loading/LoadingView';
@@ -316,6 +316,8 @@ export const App: FC<{}> = props =>
}; };
}, []); }, []);
const onSessionExpired = useEffectEvent(() => showSessionExpired());
useEffect(() => useEffect(() =>
{ {
const prepare = async (width: number, height: number) => const prepare = async (width: number, height: number) =>
@@ -379,7 +381,7 @@ export const App: FC<{}> = props =>
return; return;
} }
showSessionExpired(); onSessionExpired();
return; return;
} }
} }
@@ -432,7 +434,7 @@ export const App: FC<{}> = props =>
{ {
NitroLogger.error(err); NitroLogger.error(err);
setIsEnteringHotel(false); setIsEnteringHotel(false);
showSessionExpired(); onSessionExpired();
} }
}; };
+7 -7
View File
@@ -60,6 +60,13 @@ const saveSettings = (settings: IUiSettings): void =>
{} {}
}; };
const ALL_CSS_VARS = [
'--ui-accent-color', '--ui-accent-dark',
'--ui-ctx-bg', '--ui-ctx-header-bg', '--ui-ctx-item-bg1', '--ui-ctx-item-bg2',
'--ui-btn-primary-bg', '--ui-btn-primary-border',
'--ui-dark-bg', '--ui-dark-border'
];
const sendComposer = (composer: any): void => const sendComposer = (composer: any): void =>
{ {
try try
@@ -189,13 +196,6 @@ export const UiSettingsProvider: FC<PropsWithChildren> = ({ children }) =>
const isCustomActive = settings.colorMode !== 'default'; const isCustomActive = settings.colorMode !== 'default';
const ALL_CSS_VARS = [
'--ui-accent-color', '--ui-accent-dark',
'--ui-ctx-bg', '--ui-ctx-header-bg', '--ui-ctx-item-bg1', '--ui-ctx-item-bg2',
'--ui-btn-primary-bg', '--ui-btn-primary-border',
'--ui-dark-bg', '--ui-dark-border'
];
useEffect(() => useEffect(() =>
{ {
const root = document.documentElement; const root = document.documentElement;
@@ -1,4 +1,4 @@
import { FC, useCallback, useEffect, useMemo, useState } from 'react'; import { FC, useCallback, useEffect, useEffectEvent, useMemo, useState } from 'react';
import { Button, Column, Flex, LayoutFurniIconImageView, Text } from '../../../common'; import { Button, Column, Flex, LayoutFurniIconImageView, Text } from '../../../common';
import { FurniItem } from '../../../hooks/furni-editor'; import { FurniItem } from '../../../hooks/furni-editor';
@@ -30,9 +30,11 @@ export const FurniEditorSearchView: FC<FurniEditorSearchViewProps> = props =>
const [ sortField, setSortField ] = useState<SortField>('id'); const [ sortField, setSortField ] = useState<SortField>('id');
const [ sortDir, setSortDir ] = useState<SortDir>('asc'); const [ sortDir, setSortDir ] = useState<SortDir>('asc');
const initialSearch = useEffectEvent(() => onSearch('', '', 1));
useEffect(() => useEffect(() =>
{ {
onSearch('', '', 1); initialSearch();
}, []); }, []);
const handleSearch = useCallback(() => const handleSearch = useCallback(() =>
@@ -100,7 +100,7 @@ export const NavigatorRoomSettingsRightsTabView: FC<NavigatorRoomSettingsTabView
if(!roomData) return; if(!roomData) return;
SendMessageComposer(new RoomUsersWithRightsComposer(roomData.roomId)); SendMessageComposer(new RoomUsersWithRightsComposer(roomData.roomId));
}, [ roomData?.roomId ]); }, [ roomData ]);
return ( return (
<Grid> <Grid>
@@ -1,5 +1,5 @@
import { RequestBadgesComposer } from '@nitrots/nitro-renderer'; import { RequestBadgesComposer } from '@nitrots/nitro-renderer';
import { FC, useEffect } from 'react'; import { FC, useEffect, useEffectEvent } from 'react';
import { LocalizeText, NotificationBubbleItem, SendMessageComposer } from '../../../../api'; import { LocalizeText, NotificationBubbleItem, SendMessageComposer } from '../../../../api';
import { Flex, LayoutNotificationBubbleView, LayoutNotificationBubbleViewProps, Text } from '../../../../common'; import { Flex, LayoutNotificationBubbleView, LayoutNotificationBubbleViewProps, Text } from '../../../../common';
import { useInventoryBadges } from '../../../../hooks'; import { useInventoryBadges } from '../../../../hooks';
@@ -14,9 +14,14 @@ export const NotificationBadgeReceivedBubbleView: FC<NotificationBadgeReceivedBu
const { item = null, onClose = null, ...rest } = props; const { item = null, onClose = null, ...rest } = props;
const { badgeCodes = [], toggleBadge = null } = useInventoryBadges(); const { badgeCodes = [], toggleBadge = null } = useInventoryBadges();
useEffect(() => const requestBadgesIfEmpty = useEffectEvent(() =>
{ {
if(badgeCodes.length === 0) SendMessageComposer(new RequestBadgesComposer()); if(badgeCodes.length === 0) SendMessageComposer(new RequestBadgesComposer());
});
useEffect(() =>
{
requestBadgesIfEmpty();
}, []); }, []);
const handleWear = (event: React.MouseEvent) => const handleWear = (event: React.MouseEvent) =>