2 Commits

Author	SHA1	Message	Date
simoleo89	81656e7b19	Fix two logic bugs found while refactoring + document the open ones ... These are the bugs surfaced during the structural work that are simple enough to fix in isolation. Larger ones (race conditions that need session-token tracking, async-fetch ordering) are deferred and documented in docs/ARCHITECTURE.md "Known logic bugs" — the repo has Issues disabled, so the doc is the issue board. == Fix: room history wiped on every tab close src/components/room/widgets/room-tools/RoomToolsWidgetView.tsx had a useEffect that registered a `beforeunload` handler calling `window.localStorage.removeItem('nitro.room.history')`. The whole point of localStorage is to persist across sessions; wiping it on tab close is either a leftover debug call or a misunderstanding of the API. Removed the handler. History now persists across browser sessions, which matches user expectations. If "session-only" was the intent, the right primitive is `sessionStorage` (not localStorage + cleanup) — left as a note in the doc. == Fix: AvatarInfoPetTrainingPanelView null-pointer on session change src/components/room/widgets/avatar-info/AvatarInfoPetTrainingPanelView.tsx read `roomSession.userDataManager.getPetData(parser.petId)` without guarding for `roomSession` being null. The PetTrainingPanelMessageEvent can arrive during a room transition when `roomSession` is briefly null, crashing the widget. Added `?.` chain on both `roomSession` and `userDataManager`. == Doc: known logic bugs section Two open issues documented for follow-up: - MainView.tsx CREATED/ENDED race — needs session-token tracking, fits cleanly into the future useNitroEventReducer companion to proposal #1. - LayoutFurniImageView / LayoutAvatarImageView async fetch ordering — needs request-id refs, or solves itself once React Query (proposal #2) is enabled and the image fetch becomes a query keyed on props. Plus a "recently fixed" subsection that records the four bugs already addressed in this branch (doorbell close button, doorbell optimistic remove, room history wipe, pet panel null-pointer) so the next reader knows what changed and why. == Verification - yarn eslint on the two modified files: same error count before and after (5 pre-existing set-state-in-effect on RoomToolsWidgetView, none introduced). - yarn tsc on the two modified files: clean. https://claude.ai/code/session_01GrR87LAqnAEyKG2ZbmQt5Q	2026-05-11 16:31:52 +00:00
simoleo89	48d62c5c6b	Architecture refactor: docs + 5 pilot implementations + error boundary ... This is the structural plan promised in the previous session, with concrete pilots for all five proposals + the bonus error-boundary work. == docs/ARCHITECTURE.md (new, ~370 lines) Living document describing: - where the project stands today (event-bus pattern friction with React 19, god-hooks, oversized files); - the five proposed structural improvements with the why/how/status of each; - what's already in place across this branch; - recommended order for the next refactor PRs. This is the deliverable the rest of this commit references. == Proposal #3 + #4 pilots: src/features/doorbell/ (new) Concrete feature-folder migration on the doorbell widget (chosen because it's small enough to migrate end-to-end in one commit). src/features/doorbell/ index.ts public API views/DoorbellWidgetView.tsx hooks/useDoorbellState.ts reduces 3 events into a users array (data only) hooks/useDoorbellActions.ts answer(name, flag) (imperative actions only) The split (data vs actions) is the pattern proposal #4 wants applied to useCatalog/useChat/useWiredTools later. The original useDoorbellWidget had both concerns + a buggy `useEffect(() => setIsVisible(!!users.length), [users])` derive-state-in-effect. The new view computes visibility in render. Compat shims kept so existing imports keep working: - src/components/room/widgets/doorbell/DoorbellWidgetView.tsx -> 1-line re-export - src/hooks/rooms/widgets/useDoorbellWidget.ts -> deprecated wrapper around the two new hooks, returning the same { users, answer } shape. == Proposal #2 prototype: src/api/nitro-query/ (new) Adapter outline for wrapping composer/parser request-response pairs in TanStack Query. Not yet enabled because @tanstack/react-query is not in package.json. The file documents the activation steps: yarn add @tanstack/react-query @tanstack/react-query-devtools + mount QueryClientProvider in src/index.tsx awaitNitroResponse() throws with a helpful pointer to the doc section if called before activation, so accidental adoption fails loudly. == Proposal #5 skeleton: src/state/createNitroStore.ts (new) Same pattern: skeleton + activation instructions. Not yet enabled because zustand is not in package.json. yarn add zustand + replace the throw with `import { create } from 'zustand'; export const createNitroStore = create;` The doc inside the file shows the recommended slice shape and points to the suggested first migration target (the let isCreatingRoom singleton in NavigatorRoomCreatorView). == Bonus: WidgetErrorBoundary src/common/error-boundary/WidgetErrorBoundary.tsx wraps react-error-boundary with a sensible default (silent fallback, NitroLogger.error). Re-exported from src/common/index.ts. Applied as the umbrella around RoomWidgetsView's children — a widget crash in a room (e.g. malformed pet data) now degrades gracefully instead of unmounting the whole UI. == Verification - yarn eslint on all new + modified files: 0 errors / 0 warnings introduced. RoomWidgetsView still has its 1 pre-existing FC<{}> error (1 before, 1 after). - yarn tsc on all new files: clean (only project-wide pre-existing TS2307 about @nitrots/nitro-renderer not installed locally remains). - No regressions: existing imports of DoorbellWidgetView and useDoorbellWidget keep resolving via the compat shims. == What's NOT in this commit (intentionally) - Mass adoption of the new patterns elsewhere — left as follow-up PRs in the order documented in ARCHITECTURE.md "How to pick the next refactor PR". - Installation of @tanstack/react-query / zustand — explicit team decision, not the LLM's to make. - Test infrastructure (Vitest setup) — listed as the #1 missing piece in the doc, but a separate PR. https://claude.ai/code/session_01GrR87LAqnAEyKG2ZbmQt5Q	2026-05-11 16:31:52 +00:00