8 Commits

Author	SHA1	Message	Date
simoleo89	7435326dad	feat(navigator): useNavigatorSearch query hook (P2 core) ... useNitroQuery keyed on [currentTabCode, currentFilter] from navigatorUiStore. Fires NavigatorSearchComposer; subscribes to NavigatorSearchEvent with an accept-filter that rejects results whose code does not match the current tab. Invalidates on FlatCreatedEvent and RoomSettingsUpdatedEvent for server-driven refresh. nitro-renderer.mock.ts: add connection.send stub to GetCommunication so SendMessageComposer (which calls GetCommunication().connection.send) does not throw in tests that exercise useNitroQuery. TDD: 7 cases incl. enabled-gating, accept-filter rejection on mismatched tab, invalidator round-trip.	2026-05-27 19:18:24 +02:00
simoleo89	3c10ccdaee	fix(navigator): restore useNotification() inside useNavigatorStore ... Commit 8ab0021a introduced an unjustified deviation: it removed the useNotification() call from inside useNavigatorStore and replaced it with a module-level _simpleAlert ref + _injectSimpleAlert() exported function, on the theory that nested useBetween calls corrupt use-between's state. That diagnosis is wrong. Production proof: - useCatalog.ts:56 calls useNotification() inside useCatalogStore - useWiredToolsStore.ts:131 calls useNotification() inside its store - The original useNavigator.ts:32 calls useNotification() inside its state closure All three have been in production for ages without issue. Nested useBetween calls work fine. The smoke-test failure that prompted the workaround was a mock issue, not a real bug. Reverting to the standard pattern — useNotification() direct inside the useBetween store closure. Production alerts work again immediately without requiring an explicit injection call from consumers. Mock additions (src/nitro-renderer.mock.ts): - Added 23 notification MessageEvent subclasses (AchievementNotification- MessageEvent, ActivityPoint..., BadgeReceived, ClubGiftNotification, ClubGiftSelected, ConnectionError, HabboBroadcast, HotelClosedAndOpens, HotelClosesAndWillOpenAt, HotelWillCloseInMinutes, InfoFeedEnable, MaintenanceStatus, ModeratorCaution, ModeratorMessage, MOTD, NotificationDialog, PetLevel, PetReceived, RespectReceived, RoomEnter, SimpleAlert, UserBanned, WiredRewardResult) so useNotificationStore can register its listeners without throwing. - Added RoomEnterEffect stub (isRunning: false, totalRunningTime: 0). - Added WiredRewardResultMessageEvent static constants.	2026-05-27 18:50:40 +02:00
simoleo89	8ab0021af6	feat(navigator): wired-tools-style hook split (Store + 3 filters) ... Splits the 492-line useNavigator god-hook into a useBetween-backed useNavigatorStore closure plus three flat-shape filters (useNavigatorData, useNavigatorUiState, useNavigatorActions), mirroring the wired-tools layout. sendSearch + reloadCurrentSearch are extracted as named actions out of NavigatorView locals. Door-mode handling is removed from this store and lives in useDoorState (committed previously) - see GetGuestRoomResultEvent and GenericErrorEvent dual-subscription with mutually exclusive filters. The simpleAlert dependency is lifted out of the useBetween scope via a module-level _simpleAlert ref + _injectSimpleAlert() to avoid nested useBetween calls that corrupt use-between's module-level dispatcher state. The ref is null in tests (no events fire during smoke tests) and is populated in production by the navigator consumer before any alert is needed. The barrel index.ts no longer re-exports useNavigator. The 13 consumers will fail typecheck until the next commit migrates them; the hook files themselves are clean. Smoke test covers filter shapes. INTENTIONAL INTERMEDIATE-BROKEN COMMIT: yarn typecheck is RED at this SHA on the 13 consumer files. The next commit (consumer migration sweep) brings it back to green.	2026-05-27 18:44:24 +02:00
simoleo89	07bbc0c78d	feat(navigator): extract useDoorState (TDD) – Task 2 ... - Add `src/hooks/rooms/widgets/useDoorState.ts`: useBetween-based singleton wrapping DoorbellMessageEvent / RoomDoorbellAcceptedEvent / FlatAccessDeniedMessageEvent / GenericErrorEvent / GetGuestRoomResultEvent; all 5 handlers wrapped in useCallback([]) so their references are stable across useBetween tick() calls and the effect dep-array never triggers re-registration. - Add `src/hooks/rooms/widgets/useDoorState.test.tsx`: 11-case Vitest suite (initial state, 5 event transitions, 2 no-op guards, GetGuestRoomResultEvent doorbell/password paths, reset()). - Extend `src/nitro-renderer.mock.ts`: new MessageEvent base class with callBack/type/getParser; DoorbellMessageEvent / RoomDoorbellAcceptedEvent / FlatAccessDeniedMessageEvent / GenericErrorEvent / GetGuestRoomResultEvent concrete stubs; RoomDataParser.DOORBELL_STATE + PASSWORD_STATE; separate msgListeners map (cleared independently of NitroEvent listeners so useBetween subscriptions survive between test cases); WeakMap wrapper for correct removeMessageEvent; GetCommunication routes to msgListeners. All 11 useDoorState tests pass; full suite 453/456 (3 pre-existing FloorplanCanvasSVG jsdom/SVG-CTM failures unrelated to this task).	2026-05-26 21:35:52 +02:00
simoleo89	b540b163c6	feat(floorplan-editor): React rewrite + live in-room preview + UX polish ... Complete modernization of the floor-plan editor. Three layered changes shipped together since they share state shapes and the test infrastructure stubs. 1) React rewrite (state + hooks + views + tests) Drops the FloorplanEditorContext singleton + legacy view components and replaces them with a pure-React reducer architecture: - state/ — typed FloorplanState + FloorplanAction union, pure reducer covering PAINT_TILE / ERASE_TILE / ADJUST_HEIGHT / SET_DOOR / SET_DOOR_DIR / SET_THICKNESS / SET_WALL_HEIGHT / BRUSH_SET / SELECT_RECT / SELECT_ALL / CLEAR_SELECTION / SQUARE_SELECT_TOGGLE / IMPORT_STRING / APPLY_REMOTE_DIFF / APPLY_REMOTE_SNAPSHOT. Source-tagged ('local' | 'remote') so the editor can distinguish user edits from server pushes. Co-located encoding helpers (parseTilemap / serializeTilemap) and area-counter selectors. - hooks/ — useFloorplanReducer (wraps useReducer with a history stack + loadFromServer + undo/redo), useTool (pointer events -> dispatch), usePointerToTile (screen -> tile projection that respects the viewBox origin so pan/zoom stays accurate). - views/ — FloorplanCanvasSVG, FloorplanHeightPicker, FloorplanToolbar, FloorplanOptionsPanel, FloorplanImportExport, FloorplanTile, FloorplanPreviewSVG (alternative iso preview kept as a fallback view, not wired into the main layout). - Co-located Vitest suites for every module above (encoding, reducer, selectors, hooks, views, integration). 100+ new test cases. 2) Live in-room preview (NEW capability) useFloorplanLiveSync drives client-side preview of the edit directly into the active room — every tile / door / wall height / thickness change is applied through GetRoomMessageHandler().applyFloorModelLocally (new public method on the renderer, see paired renderer PR) with zero server traffic during editing. The wire UpdateFloorPropertiesMessageComposer is only sent when the user explicitly clicks Save. Thickness slider additionally calls RoomEngine.updateRoomInstancePlaneThickness for zero-latency wall/floor-depth feedback while dragging. Toggle 'Live preview ON / OFF' in the bottom strip (default ON) lets the user opt out if they want to keep changes contained to the editor's own preview until Save. Revert button re-applies the original snapshot locally so the room snaps back to where it was when the editor opened. 3) UX polish - Undo / Redo (Ctrl+Z, Ctrl+Shift+Z / Ctrl+Y) backed by a 100-step history stack inside useFloorplanReducer. Local mutating actions push history; brush/selection UI bumps and remote dispatches bypass it; loadFromServer wipes the stack. - Zoom 40-600 % with Ctrl+wheel, +/- buttons, % label. Shift+drag or middle-mouse drag pans the canvas. - Auto-fit on first paint: computes the screen-space bounding box of the painted (non-blocked) tiles, picks the zoom that just contains them with a 5 % margin, pans so the room sits in the viewport centre. Default view is now 'room fills the canvas' instead of 'room is a dot at the top-centre of a huge empty canvas'. Clicking the % label re-runs the fit; crosshair button keeps zoom and recentres the pan only. - Door direction control: arrows + door icon triplet (8-way rotate by single click on prev/next, full cycle forward on the icon itself). Wall and floor thickness collapse from two 4-button rows into two compact segmented selectors (active state in emerald). Saves significant horizontal space. - Habbo floor pattern tile (~186 B PNG, vendored from habbofurni.com/images/furni_floor.png) tiled as the canvas background with image-rendering: pixelated so the texture stays crisp at every zoom level. Replaces the solid black background. Test infrastructure nitro-renderer.mock grows constructors / proxies / functions for everything the new floor-editor tests transitively import (floor composers + events, RoomEngineEvent, ILinkEventTracker, convertNumbersForSaving / convertSettingToNumber, GetRoomMessageHandler, GetTicker, GetRenderer, NitroTicker, RoomPreviewer with a sufficiently real .updatePreviewModel / dispose surface, and a TextureUtils.createRenderTexture that returns an object with a no-op .destroy). test-setup adds a no-op ResizeObserver polyfill (jsdom doesn't ship one and the optional FloorplanRoomPreview observes its container) and a draggable-windows-container portal root for tests that mount NitroCardView. Files: 44 changed (mostly new). yarn typecheck 0 errors, yarn test 341/341 green.	2026-05-24 21:19:10 +02:00
simoleo89	8aa02249e1	feat(hooks): rank-based API tied to permission_ranks DB table ... Drop the SecurityLevel-named family (useIsModerator / useIsAdmin / useIsCommunity / useIsPlayerSupport / useHasSecurityLevel / useUserSecurityLevel) in favour of a rank-based family tied to the operator's actual `permission_ranks` rows in the Arcturus DB: - `useUserRank()` returns `{ id, name, level, badge, prefix, prefixColor }` derived from the snapshot. Powered by the renderer's extended IUserDataSnapshot (companion commit 87e67d5 on feat/react19-event-bus). - `useHasRankLevel(min)` replaces useHasSecurityLevel; consumers pass a `permission_ranks.level` threshold from the deployment. - `useIsRank(name)` matches `permission_ranks.rank_name` exactly. To avoid bare integers in widget bodies, added a deployment-scoped constants file at `src/api/nitro/session/RankLevels.ts`: export const STAFF_LEVELS = { MEMBER: 1, SUPPORT: 4, MOD: 5, SUPER_MOD: 6, ADMIN: 7 }; A deployment that re-numbers `permission_ranks` only edits this file. Migrated all 11 consumer reads (same set as the earlier session's useIsModerator migration plus the audit catch): ToolbarView, CatalogClassicView, CatalogModernView, ChooserWidgetView, CalendarView, YouTubePlayerView, FurniEditorView, InfoStandWidgetFurniView, AvatarInfoWidgetPetView, FurnitureMannequinView, NavigatorRoomInfoView. The NavigatorRoomInfoView `staff_pick` permission was previously `securityLevel >= COMMUNITY (7)` via the renderer-enum wrapper — ported to `useHasRankLevel(STAFF_LEVELS.ADMIN)` because in the default seed level 7 is Administrator, which is the actual rank that gets the `acc_anyroomowner`-style permissions for staff-picking. Tests refreshed under `useSessionSnapshots.test.tsx`: - useUserRank surfaces the full metadata block; - useHasRankLevel does `>=` against the threshold; - useIsRank exact-matches against rank_name; - a runtime promote (snapshot mutation + SESSION_DATA_UPDATED dispatch) flips the result, locking in the reactive contract. Mock extended only minimally — kept the SecurityLevel enum class for any consumer outside the dropped family that still imports it. Verification: yarn typecheck clean, yarn lint:hooks clean, yarn test 213/213. The Arcturus-side composer change (UserPermissionsComposer appending the 5 extra fields) is staged but UNCOMMITTED on Arcturus main (which has unrelated WIP); the wire is backward-compatible so the React client works against both pre- and post-extension emulators.	2026-05-19 18:38:31 +02:00
simoleo89	c11a6c4699	feat(hooks): generalise security-level family + audit catch + reactivity test ... Build on the useIsModerator landing (532cb28c) along three axes: 1. Family. Extract `useHasSecurityLevel(min)` as the primitive, backed by a fresh `useUserSecurityLevel()` raw-level reader. The six SecurityLevel constants (1..9) deserve named wrappers so the "show this only to X-and-up" pattern doesn't get re-derived ad-hoc each time: shipped `useIsModerator` / `useIsPlayerSupport` / `useIsCommunity` / `useIsAdmin` as one-line shims. Also added `useIsAmbassador()` as a sibling — not derived from security level, reads the boolean field on the snapshot directly. 2. Audit. The 532cb28c migration covered 6 React-render reads but missed 5 more discovered by a follow-up grep: - FurniEditorView (top-level `const isMod`) - InfoStandWidgetFurniView (inline JSX, mod-only build-tools button) - NavigatorRoomInfoView (3 reads in hasPermission(): isModerator and securityLevel >= COMMUNITY for the staff-pick gate. The userId read stays imperative — userId doesn't flip at runtime in practice, no reactivity gain.) - AvatarInfoWidgetPetView (inside useMemo with [roomSession] deps; migrated and isModerator added to the deps so a runtime promote/demote re-derives canPickUp without remount) - FurnitureMannequinView (inside useEffect; same treatment — added isModerator to the deps so the mode re-resolves on flip) The remaining ~17 reads (CanManipulateFurniture, AvatarInfoUtilities.populate*, useChatInputActions, useFurnitureDimmerWidget / useFurniturePlaylistEditorWidget / useFurnitureStickieWidget canModify checks, useCatalog admin filter, useNavigator door-mode guard) are click-time / event-time imperative — they read at the moment a user action fires, so a reactive value would be cached at hook execution and stale by the time the action runs. Leaving them on the synchronous manager read is correct. 3. Test. Added four cases pinning the contract: - useUserSecurityLevel returns the raw level. - useHasSecurityLevel does `>=` against the threshold. - Named wrappers map to the right constants (MODERATOR=5, COMMUNITY=7, ADMINISTRATOR=8). - **Reactive flip** — mutate the snapshot, dispatch the SESSION_DATA_UPDATED event on the mock dispatcher, assert the hook re-derives. Locks in the whole point of the snapshot pattern (a static read would pass cases 1-3 but fail case 4). Mock changes: - Added SecurityLevel class (mirrors the renderer enum 0..9) so the family wrappers resolve to actual numbers in jsdom — without it `useIsModerator()` would call `useHasSecurityLevel(undefined)` and the test would silently pass false-positives. Verification: yarn typecheck clean, yarn lint:hooks clean, yarn test 213/213 (209 baseline + 4 new family/reactivity cases).	2026-05-19 18:18:20 +02:00
simoleo89	803de20dfe	tests: flatten renderer mock to src/nitro-renderer.mock.ts (drop __mocks__/) ... The Jest-style __mocks__/ folder added one indirection for a single file. Move the stub to src/nitro-renderer.mock.ts at src/ root next to test-setup.ts, drop the folder, repoint the vitest alias, and update the lone test that imports the helpers directly (useDoorbellState). Same behaviour, one fewer directory.	2026-05-16 11:37:33 +02:00