2 Commits

Author	SHA1	Message	Date
simoleo89	fd3ef7875d	catalog: extract pure helpers + 34 cases, consume them from useCatalog ... First half of the proposed `useCatalog` decomposition. The 1036-line god-hook still owns the singleton-via-useBetween, but the pure logic it used to define inline now lives in a dependency-free module so it can be tested in isolation and reused by future split-out hooks (`useCatalogData` / `useCatalogUiState` / `useCatalogActions` when those land). New module: `src/hooks/catalog/useCatalog.helpers.ts` (222 LOC). - `normalizeCatalogType(type?)` — coerce the optional catalog type to `NORMAL` / `BUILDER`. Was a 5-line `useCallback` with an empty dependency array. - `getOfferProductKeys(offer)` — produces the canonical `productType:id:classId` and `productType:class:className` keys for the resolved-offer cache. - `findNodeById` / `findNodeByName` — DFS over the catalog tree, root explicitly excluded so callers can't select the synthetic root by mistake. - `getNodesByOfferIdFromMap(offerId, map, onlyVisible)` — extracted from the closed-over `getNodesByOfferId`. The `onlyVisible` fallback to the full bucket when nothing visible remains is preserved. - `buildCatalogNodeTree(NodeData)` — pulled out of the `CatalogPagesListEvent` reducer. Builds the tree and the offerId index in one pass; the caller now does `const { rootNode, offersToNodes } = buildCatalogNodeTree(parser.root)` instead of carrying an inline recursive walker + a local map. - `resolveBuilderFurniPlaceableStatus(input)` — the placement decision tree as a pure function. The hook keeps the `GetRoomEngine` / `GetSessionDataManager` reads that count non-self, non-moderator visitors (only when the subscription has expired) and forwards the resulting `visitorCount` into the helper, so the previous early-exit semantics are preserved. `useCatalog.ts` now imports these and removes ~140 lines of inline copies. Net hook size: 1036 → 961 LOC. Behavior unchanged. Tests: `tests/useCatalog.helpers.test.ts` (34 cases). - `normalizeCatalogType` (4) — BUILDER pass-through, NORMAL pass-through, undefined/empty fallback, unknown string fallback. - `getOfferProductKeys` (5) — both keys, id-only when classId<0, class-only when className empty, no-product short-circuit, empty productType short-circuit. - `findNodeById` (5) — null input, root exclusion, immediate child, grandchild, miss returns null. - `findNodeByName` (2) — match by name + root exclusion, miss. - `getNodesByOfferIdFromMap` (5) — empty map, raw bucket pass-through, visible-only filter, fallback when no visible remain, miss. - `buildCatalogNodeTree` (3) — root depth=0 + empty offer map for a leaf-only root, DFS traversal tracks offer→nodes across branch and leaf, child.parent === root. - `resolveBuilderFurniPlaceableStatus` (10) — missing offer, not-in-room, owner happy path, non-owner without fallback, guild admin with time, furni limit reached, shared-pool override ignoring the limit, expired+blocked-by-visitors flag, expired+visitor count > 0, expired+empty room is okay. To support the placement-status test the renderer mock gains real numeric values for `RoomControllerLevel` (NONE..MODERATOR) and `RoomObjectCategory` (MINIMUM..MAXIMUM); the previous string-keyed Proxy stubs made `controllerLevel >= GUILD_ADMIN` evaluate to NaN. Suite: 158/158 (was 124/124). `yarn typecheck` green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-13 21:42:04 +02:00
simoleo89	c4018392f9	tests: add renderer-SDK mock layer + first 2 component-/hook-level pilots ... Foundations for widening Vitest coverage past the pure-helper subset. The real `@nitrots/nitro-renderer` eagerly loads Pixi v8 and the full Habbo message parser/composer registry at module-import time, which jsdom cannot host: any `tests/**` file that transitively pulled a renderer symbol would throw before a single assertion ran. That's why the existing 8 suites all stuck to pure modules imported by concrete path and used `import type` for renderer-side names. Add a stub at `tests/mocks/renderer-mock.ts`, aliased over the package via `vitest.config.mts`. It exports: - Explicit behavioral stubs for the symbols tests actually exercise: `NitroLogger`, `GetEventDispatcher`, the `mockEventDispatcher` helper with `addEventListener` / `removeEventListener` / `dispatchEvent` / `hasListeners`, and `RoomSessionDoorbellEvent` (signature matches the real `(type, session, userName)` to keep tsgo happy). - String-keyed Proxy enums for `NitroEventType`, `RoomObjectCategory`, `AvatarFigurePartType`, etc. — each access returns a stable unique string so dispatch and listener agree. - Lightweight `class StubClass {}` placeholders for the ~30 Pixi and gameplay classes the `src/api/*` barrel touches at import time (`NitroAlphaFilter`, `NitroContainer`, `EventDispatcher`, …). Keeps the cascade from throwing without simulating behavior tests don't care about. - Singleton getters (`GetAssetManager`, `GetCommunication`, `GetSessionDataManager`, …) returning a chainable Proxy so deeply nested `GetX().y.z(…)` access evaluates to no-op proxies. Pilots on top of that layer (each one designed to catch a different class of regression): - `tests/WidgetErrorBoundary.test.tsx` (4 cases) — happy path, default silent fallback + `NitroLogger.error` call, custom fallback node, default `unknown` widget name. - `tests/useDoorbellState.test.tsx` (7 cases) — initial empty state, append on `RSDE_DOORBELL`, dedup duplicate names, remove on `RSDE_ACCEPTED` / `RSDE_REJECTED`, ignore stale events for never-pending users, full unsubscribe on unmount. Suite count now 124/124 across 10 files (was 113/113 across 8). `yarn typecheck` still green. Docs: CLAUDE.md's Vitest row and "Where everything lives" pointer updated; `docs/ARCHITECTURE.md` Tests section now lists the new suites + a description of what the mock layer covers, and the "Wider Vitest coverage" entry in the next-steps list is reframed from "needs a renderer mock" to "pick the next adopter". Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-13 21:31:08 +02:00