Nitro-V3/src/api/avatar/index.ts at 0b010eac7e311e910efb13222f6f7f9a8a5d05b6 - Nitro-V3 - Github Camwijs

duckietm/Nitro-V3

mirror of https://github.com/duckietm/Nitro-V3.git synced 2026-06-19 15:06:20 +00:00

Files

T

simoleo89 559d860a7b Pilot: move InfoStand event listeners to useAvatarInfoWidget owner

InfoStandWidgetUserView previously subscribed to three room-session
events (RSUBE_BADGES, USER_FIGURE, FAVOURITE_GROUP_UPDATE) and pushed
the result back to its parent via a setAvatarInfo prop, with each
handler running CloneObject(prev) before patching one field. Three
issues with that shape:

- CloneObject was deep-cloning the whole AvatarInfoUser shape blindly
  with no class-prototype awareness;
- the three listeners raced on shallow merges across the same prev
  reference in StrictMode dev;
- the subscriptions lived outside the state owner, forcing a prop
  callback barrier per event.

The subscriptions are now in useAvatarInfoWidget — the actual owner of
avatarInfo — and call three pure reducers extracted to
src/hooks/rooms/widgets/avatarInfo.reducers.ts (applyUserBadgesUpdate,
applyUserFigureUpdate, applyFavouriteGroupUpdate). Each reducer returns
the same reference when the event doesn't apply so React bail-outs work.
The clone now constructs a fresh AvatarInfoUser preserving prototype.

dedupeBadges is extracted to its own pure module under src/api/avatar/
so Vitest can cover it without pulling in the renderer.

InfoStandWidgetUserView loses the setAvatarInfo prop (parent updated)
and the CloneObject import.

2026-05-11 21:11:02 +02:00

9 lines

343 B

TypeScript

Raw Blame History

 export * from './AvatarEditorAction';
 export * from './AvatarEditorColorSorter';
 export * from './AvatarEditorPartSorter';
 export * from './AvatarEditorThumbnailsHelper';
 export * from './BuildPurchasableClothingFigure';
 export * from './dedupeBadges';
 export * from './IAvatarEditorCategory';
 export * from './IAvatarEditorCategoryPartItem';