mirror of
https://github.com/duckietm/Nitro-V3.git
synced 2026-06-19 15:06:20 +00:00
8b79233059
The 5 pure functions inside useCatalogFavorites
(normalizeCatalogType, getOffersStorageKey, getPagesStorageKey,
parseOffers, parsePages) handle the v2 -> v3 storage-key migration
that runs once per user the first time they open the v3 client. The
parseOffers branch in particular silently morphs the legacy number[]
shape into IFavoriteOffer[] — exactly the kind of one-shot migration
code that should have coverage so a refactor doesn't break old saves.
Move them into useCatalogFavorites.helpers.ts (sibling file, matching
the WiredCreatorTools / useInventoryFurni.reducers / avatarInfo.reducers
convention). useCatalogFavorites imports them back, plus re-exports
the IFavoriteOffer type from the helper module for the public API.
Both helpers import CatalogType from the concrete file path
('../../api/catalog/CatalogType') rather than the api barrel, so the
test file doesn't drag in the renderer SDK and run aground in jsdom.
Tests cover:
- normalizeCatalogType fallback to NORMAL on undefined/garbage/explicit
- storage-key routing for NORMAL / BUILDER / missing arg
- parseOffers: invalid JSON, non-array, empty array, v2 number[] migration,
v3 IFavoriteOffer[] passthrough, mixed-array passthrough
- parsePages: invalid JSON, non-array, normal array
Net Vitest count: 83 -> 99 (7 test files).
120 lines
3.9 KiB
TypeScript
120 lines
3.9 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import { CatalogType } from '../src/api/catalog/CatalogType';
|
|
import { getOffersStorageKey, getPagesStorageKey, normalizeCatalogType, parseOffers, parsePages, STORAGE_KEY_OFFERS_BUILDER, STORAGE_KEY_OFFERS_NORMAL, STORAGE_KEY_PAGES_BUILDER, STORAGE_KEY_PAGES_NORMAL } from '../src/hooks/catalog/useCatalogFavorites.helpers';
|
|
|
|
describe('normalizeCatalogType', () =>
|
|
{
|
|
it('returns NORMAL when nothing is passed', () =>
|
|
{
|
|
expect(normalizeCatalogType()).toBe(CatalogType.NORMAL);
|
|
});
|
|
|
|
it('returns NORMAL for unknown strings', () =>
|
|
{
|
|
expect(normalizeCatalogType('not-a-real-type')).toBe(CatalogType.NORMAL);
|
|
});
|
|
|
|
it('returns BUILDER only for the exact BUILDER constant', () =>
|
|
{
|
|
expect(normalizeCatalogType(CatalogType.BUILDER)).toBe(CatalogType.BUILDER);
|
|
});
|
|
|
|
it('returns NORMAL for NORMAL explicitly', () =>
|
|
{
|
|
expect(normalizeCatalogType(CatalogType.NORMAL)).toBe(CatalogType.NORMAL);
|
|
});
|
|
});
|
|
|
|
describe('getOffersStorageKey / getPagesStorageKey', () =>
|
|
{
|
|
it('routes the BUILDER catalog to the builder storage keys', () =>
|
|
{
|
|
expect(getOffersStorageKey(CatalogType.BUILDER)).toBe(STORAGE_KEY_OFFERS_BUILDER);
|
|
expect(getPagesStorageKey(CatalogType.BUILDER)).toBe(STORAGE_KEY_PAGES_BUILDER);
|
|
});
|
|
|
|
it('routes the NORMAL catalog to the normal storage keys', () =>
|
|
{
|
|
expect(getOffersStorageKey(CatalogType.NORMAL)).toBe(STORAGE_KEY_OFFERS_NORMAL);
|
|
expect(getPagesStorageKey(CatalogType.NORMAL)).toBe(STORAGE_KEY_PAGES_NORMAL);
|
|
});
|
|
|
|
it('falls back to NORMAL keys for unknown / missing catalog type', () =>
|
|
{
|
|
expect(getOffersStorageKey()).toBe(STORAGE_KEY_OFFERS_NORMAL);
|
|
expect(getOffersStorageKey('garbage')).toBe(STORAGE_KEY_OFFERS_NORMAL);
|
|
expect(getPagesStorageKey()).toBe(STORAGE_KEY_PAGES_NORMAL);
|
|
expect(getPagesStorageKey('garbage')).toBe(STORAGE_KEY_PAGES_NORMAL);
|
|
});
|
|
});
|
|
|
|
describe('parseOffers', () =>
|
|
{
|
|
it('returns an empty array on invalid JSON', () =>
|
|
{
|
|
expect(parseOffers('not json')).toEqual([]);
|
|
expect(parseOffers('{')).toEqual([]);
|
|
});
|
|
|
|
it('returns an empty array when the parsed value is not an array', () =>
|
|
{
|
|
expect(parseOffers('null')).toEqual([]);
|
|
expect(parseOffers('{}')).toEqual([]);
|
|
expect(parseOffers('42')).toEqual([]);
|
|
expect(parseOffers('"hello"')).toEqual([]);
|
|
});
|
|
|
|
it('returns an empty array unchanged', () =>
|
|
{
|
|
expect(parseOffers('[]')).toEqual([]);
|
|
});
|
|
|
|
it('migrates the v2 number[] format into IFavoriteOffer[] with offerId only', () =>
|
|
{
|
|
expect(parseOffers('[101, 202, 303]')).toEqual([
|
|
{ offerId: 101 },
|
|
{ offerId: 202 },
|
|
{ offerId: 303 }
|
|
]);
|
|
});
|
|
|
|
it('passes through a well-formed v3 IFavoriteOffer[] unchanged', () =>
|
|
{
|
|
const v3 = [
|
|
{ offerId: 5, name: 'red sofa', iconUrl: 'http://example.com/sofa.png' },
|
|
{ offerId: 9 }
|
|
];
|
|
|
|
expect(parseOffers(JSON.stringify(v3))).toEqual(v3);
|
|
});
|
|
|
|
it('only triggers migration when the first element is a number (mixed arrays go through as-is)', () =>
|
|
{
|
|
const mixed = [ { offerId: 1 }, { offerId: 2 } ];
|
|
|
|
expect(parseOffers(JSON.stringify(mixed))).toEqual(mixed);
|
|
});
|
|
});
|
|
|
|
describe('parsePages', () =>
|
|
{
|
|
it('returns an empty array on invalid JSON', () =>
|
|
{
|
|
expect(parsePages('not json')).toEqual([]);
|
|
expect(parsePages('}{')).toEqual([]);
|
|
});
|
|
|
|
it('returns an empty array when the parsed value is not an array', () =>
|
|
{
|
|
expect(parsePages('null')).toEqual([]);
|
|
expect(parsePages('{ "pages": [1, 2] }')).toEqual([]);
|
|
expect(parsePages('"42"')).toEqual([]);
|
|
});
|
|
|
|
it('returns the parsed array as-is', () =>
|
|
{
|
|
expect(parsePages('[]')).toEqual([]);
|
|
expect(parsePages('[1, 2, 3]')).toEqual([ 1, 2, 3 ]);
|
|
});
|
|
});
|