duckietm/Nitro_Render_V3
1
0
Fork 0
mirror of https://github.com/duckietm/Nitro_Render_V3.git synced 2026-06-19 23:16:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(session): invalidate RoomSession snapshot on room-data and permission changes

Browse Source 
getActiveRoomSessionSnapshot() caches the frozen snapshot keyed on the session
reference, but RoomDataHandler (tradeMode/groupId/isGuildRoom/doorMode/allowPets)
and RoomPermissionsHandler (controllerLevel/owner) mutate those fields on the
same session object without invalidating the cache. Any consumer reading a
mutable field via useActiveRoomSessionSnapshot would get stale data and never
re-render.

Expose invalidateRoomSessionSnapshot() on IRoomHandlerListener and call it from
both handlers after they mutate the session.
This commit is contained in:
simoleo89
2026-06-13 15:15:13 +02:00
parent a49c835870
commit 3ce15e5819
4 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/session/src/RoomSessionManager.ts
+1 -1
View File
@@ -28,7 +28,7 @@ export class RoomSessionManager implements IRoomSessionManager, IRoomHandlerList
private _savedPosY: number = -1;
private _activeRoomSessionSnapshot: Readonly<IRoomSessionSnapshot> | null = null;
private invalidateRoomSessionSnapshot(): void
public invalidateRoomSessionSnapshot(): void
{
this._activeRoomSessionSnapshot = null;