duckietm/Nitro_Render_V3
1
0
Fork 0
mirror of https://github.com/duckietm/Nitro_Render_V3.git synced 2026-06-19 15:06:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

📝 Fixed some memory problems

Browse Source 
RenderTexture leak in IsometricImageFurniVisualization, every direction change or thumbnail update leaked a GPU RenderTexture.
Image object leak in FurnitureDynamicThumbnailVisualization, now clears callbacks and src after use.
Image object leak in FurnitureBadgeDisplayVisualization, image objects never cleaned up
This commit is contained in:
duckietm
2026-03-31 15:20:28 +02:00
parent 2138d3a820
commit 44cb722f54
3 changed files with 29 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/room/src/object/visualization/furniture/FurnitureBadgeDisplayVisualization.ts
+9
View File
@@ -340,6 +340,15 @@ export class FurnitureBadgeDisplayVisualization extends FurnitureAnimatedVisuali
ctx.clearRect(0, 0, badgeCanvas.width, badgeCanvas.height);
ctx.drawImage(img, 0, 0, badgeCanvas.width, badgeCanvas.height);
tex.source.update();
img.onload = null;
img.onerror = null;
img.src = '';
};
img.onerror = () =>
{
img.onload = null;
img.onerror = null;
img.src = '';
};
img.src = badgeUrl;
}
packages/room/src/object/visualization/furniture/FurnitureDynamicThumbnailVisualization.ts
+6
View File
@@ -33,10 +33,16 @@ export class FurnitureDynamicThumbnailVisualization extends IsometricImageFurniV
} else {
this.setThumbnailImages(null);
}
image.onload = null;
image.onerror = null;
image.src = '';
};
image.onerror = () => {
this.setThumbnailImages(null);
image.onload = null;
image.onerror = null;
image.src = '';
};
} else {
this.setThumbnailImages(null);
packages/room/src/object/visualization/furniture/IsometricImageFurniVisualization.ts
+14 -3
View File
@@ -61,6 +61,9 @@ export class IsometricImageFurniVisualization extends FurnitureAnimatedVisualiza
if (this._thumbnailImageNormal) {
this.addThumbnailAsset(this._thumbnailImageNormal, 64);
} else {
if (this._thumbnailTexture instanceof RenderTexture) {
this._thumbnailTexture.destroy(true);
}
this._thumbnailTexture = null;
this._thumbnailLayerId = -1;
}
@@ -82,6 +85,9 @@ export class IsometricImageFurniVisualization extends FurnitureAnimatedVisualiza
const asset = this.getAsset(assetName, layerId);
if (asset) {
if (this._thumbnailTexture instanceof RenderTexture) {
this._thumbnailTexture.destroy(true);
}
this._thumbnailTexture = this.generateTransformedThumbnail(k, asset);
}
@@ -106,6 +112,7 @@ export class IsometricImageFurniVisualization extends FurnitureAnimatedVisualiza
protected generateTransformedThumbnail(texture: Texture, asset: IGraphicAsset): Texture {
const assetWidth = asset.width;
const assetHeight = asset.height;
let outlineTexture: RenderTexture = null;
if(this._hasOutline)
{
@@ -124,10 +131,10 @@ export class IsometricImageFurniVisualization extends FurnitureAnimatedVisualiza
container.addChild(background, imageSprite);
const flatRenderTexture = RenderTexture.create({ width: bgWidth, height: bgHeight, resolution: 1 });
GetRenderer().render({ container, target: flatRenderTexture, clear: true });
outlineTexture = RenderTexture.create({ width: bgWidth, height: bgHeight, resolution: 1 });
GetRenderer().render({ container, target: outlineTexture, clear: true });
texture = flatRenderTexture;
texture = outlineTexture;
}
texture.source.scaleMode = 'linear';
@@ -197,6 +204,10 @@ export class IsometricImageFurniVisualization extends FurnitureAnimatedVisualiza
const renderTexture = RenderTexture.create({ width: renderWidth, height: renderHeight, resolution: 1 });
GetRenderer().render({ container: transformedSprite, target: renderTexture, clear: true });
if (outlineTexture) {
outlineTexture.destroy(true);
}
return renderTexture;
}