duckietm/Nitro_Render_V3
1
0
Fork 0
mirror of https://github.com/duckietm/Nitro_Render_V3.git synced 2026-06-19 15:06:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs(CLAUDE): note outgoing-composer registration + audit both _events/_composers

Browse Source 
Captures the session learning behind the dead Prefixes panel: NitroMessages has
two maps (_events for incoming, _composers for outgoing); a feature needs both
directions registered, and an unregistered composer silently drops the packet
("Unknown Composer", getComposerId === -1). Audit both maps when a panel is dead.
This commit is contained in:
simoleo89
2026-06-14 13:42:48 +02:00
parent a49c835870
commit 51c8d0468e
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CLAUDE.md
+12
View File
@@ -294,6 +294,18 @@ furni-editor's `applyLiveFurnitureNameUpdate`.
Parser under `messages/incoming/<area>` + `messages/parser/<area>` -> wire the
barrel chain (`<area>/index.ts` -> parent `index.ts` -> package `src/index.ts`).
**Adding an outgoing composer:** id in `OutgoingHeader.ts` -> register in
`NitroMessages.ts` (`this._composers.set(OutgoingHeader.X, XComposer)`) -> Composer
under `messages/outgoing/<area>` -> wire the barrel chain. An unregistered composer
makes `getComposerId()` return -1, logs "Unknown Composer", and the packet is
silently DROPPED — the request never reaches the server.
**A feature usually needs BOTH directions registered.** `NitroMessages` holds two
maps — `_events` (incoming) and `_composers` (outgoing). When a panel is "dead",
audit BOTH, not just `_events`: the inventory Prefixes panel was broken because
`UserPrefixesEvent` (7001, incoming) AND `RequestPrefixesComposer` (7011, outgoing)
were both defined+exported but never `set()` in `NitroMessages`.
**Gotchas:**
- A branch based on `origin/Dev` may NOT contain the furni-editor slice
(`FurniDataUpdatedEvent` / `applyLiveFurnitureNameUpdate`) — verify, don't assume.